cairo-vm icon indicating copy to clipboard operation
cairo-vm copied to clipboard

dev: make `VirtualMachine::get_traceback_entries` pub

Open ksew1 opened this issue 10 months ago • 1 comments

Make VirtualMachine::get_traceback_entries pub

Description

Made VirtualMachine::get_traceback_entries so it can be used in starknet-foundry backtrace feature

Checklist

  • [ ] Linked to Github Issue
  • [ ] Unit tests added
  • [ ] Integration tests added.
  • [ ] This change requires new documentation.
    • [ ] Documentation has been added/updated.
    • [x] CHANGELOG has been updated.

ksew1 avatar Jun 18 '25 10:06 ksew1

Hi, @ksew1, thanks for contributing! I have some questions:

  • Why does Scarb need this function for the backtrace feature?
  • How does this feature currently work without this function?

Also, as a side note: The VM also defines get_traceback which might be sufficient.

gabrielbosio avatar Jun 18 '25 21:06 gabrielbosio

Hi, @ksew1, thanks for contributing! I have some questions:

* Why does Scarb need this function for the backtrace feature?

* How does this feature currently work without this function?

Also, as a side note: The VM also defines get_traceback which might be sufficient.

How does this feature currently work without this function?

This is how it is currently done

Why does Scarb need this function for the backtrace feature?

We need pc as we map them to function names and lines using annotations for compiler

ksew1 avatar Jul 07 '25 11:07 ksew1

@ksew1 I think this PR looks good but you need to sign your commits to get the CI working.

gabrielbosio avatar Jul 23 '25 20:07 gabrielbosio

@ksew1 I think this PR looks good but you need to sign your commits to get the CI working.

Should be signed now

ksew1 avatar Jul 24 '25 10:07 ksew1