dev: make `VirtualMachine::get_traceback_entries` pub
Make VirtualMachine::get_traceback_entries pub
Description
Made VirtualMachine::get_traceback_entries so it can be used in starknet-foundry backtrace feature
Checklist
- [ ] Linked to Github Issue
- [ ] Unit tests added
- [ ] Integration tests added.
- [ ] This change requires new documentation.
- [ ] Documentation has been added/updated.
- [x] CHANGELOG has been updated.
Hi, @ksew1, thanks for contributing! I have some questions:
- Why does Scarb need this function for the backtrace feature?
- How does this feature currently work without this function?
Also, as a side note: The VM also defines get_traceback which might be sufficient.
Hi, @ksew1, thanks for contributing! I have some questions:
* Why does Scarb need this function for the backtrace feature? * How does this feature currently work without this function?Also, as a side note: The VM also defines get_traceback which might be sufficient.
How does this feature currently work without this function?
This is how it is currently done
Why does Scarb need this function for the backtrace feature?
We need pc as we map them to function names and lines using annotations for compiler
@ksew1 I think this PR looks good but you need to sign your commits to get the CI working.
@ksew1 I think this PR looks good but you need to sign your commits to get the CI working.
Should be signed now