Ken Scambler

Params.unapply missing explicit type, doesn't compose, and has lying docs

2

Hi there, Couldn't find a duplicate, searching for "Params" or "unapply", so raising an issue. The documentation of unfiltered.request.Params.unapply indicates that it destructures to (Map[...], HttpRequest). This would allow the...

MatchError using `as` inside Focus

4

Playing with this codebase: https://github.com/bblfish/lens-play/blob/master/src/main/scala/server/Server.scala ``` sbt> console scala> import monocle.syntax.all._; import server._; import Server._ scala> val container = Container(Map("foo" -> Container(Map("bar" -> TextResource("banana"))))) val container: server.Server.Container = Container(Map(foo ->...

- [ ] Add line numbers for compiler errors in Focus block, so it points to the right spot - [ ] Generator errors resulting in `Nothing` should be intercepted...

Communication strategy

3

I think the website, scaladoc, code/variable naming, import interface and compiler error messages all have to form one coherent, clearly stated communication strategy for 3.0 release. They all have to...

1. Applied/unapplied symmetry `Focus[A](_.actions).command(a) == a.focus(_.actions).command` 2. Internal/external operator symmetry `Focus[A](_.actions.keyword) == Focus[A](_.actions).keyword` 3. Internal/external composition symmetry `Focus[A](_.action1.action2) == Focus[A](_.action1).andThen(Focus[B](_.action2))` 4. Internal/external composition associativity `Focus[A](_.action1.action2).andThen(Focus[C](_.action3)) == Focus[A](_.action1).andThen(Focus[B](_.action2.action3))`

Variance for optics type parameters

1

Add variance to the optics type parameters, eg `[-S, +T, +A, -B]`. Julien: > It helps with `Some(1).focus(_.some).replace(2)` > Without variance, I believe you get an error and need to...

Renaming optics type parameters

1

The traditional STAB naming of type parameters is obscure and a barrier to learning. Proposed new names: `PLens[SourceIn, SourceOut, TargetOut, TargetIn]` `Lens[Source, Target]` to be applied consistently across all code....

Replace Specs2 with uTest

1

Specs2 doesn't have a great ScalaJS story at the moment. We are not using any fancy features with our tests at the moment, we just need asserts and ScalaCheck. If...

On my poor Windows 10 default, the unicode borders of the fancy error tables turn into question marks: ``` Sections ? Types ? Optics ??????????????????????????????????????????????????????????????????????? $myBasket ? ShoppingBasket ? .items...

Shortcut for Iso.id to introduce type in lens mode

3

Lens mode has to start with an interpolated optic, so that it knows the type to start with. If you want to start with something else, it's possible to put...