Kyle Barbary
Kyle Barbary
This seems much nicer than the current approach. One could simplify this slightly using the `Val` type from Base instead of `ParamIndexes`: define, e.g. `getindex(sp::SourceParams, ::Type{Val{:u}})`, and index like `sp[Val{:u}]`....
https://github.com/sphinx-gallery/sphinx-gallery could be good for this.
Out of curiousity, can you give an example of how SkyCoords types with unit parameters would be used in AstroLib?
I haven't used concurrent.futures before, so it might take me a bit to get up to speed with this, but the general idea sounds good.
I sort of like that this parallel functionality is Python 3 only. :grinning: However, I'm wondering if there is a way to generalize this a bit so that it could...
n_queue: Ah, I had assumed that the Executors provided this. Makes sense to keep it then. For consistency with the other `n*` parameters (`ndim`, `npoints`, `npdim`, `niter`, `ncall`) can we...
Thoughts for the future: If an `MPIPoolExecutor` class is added to nestle, it might be time to move from a single python module to a package. Feroz et al (2007)...
Tests would be great. I was going to write some if you didn't. Can just skip tests if concurrent.futures isn't available. (Some tests are already skipped if scipy isn't available.)...
I didn't notice your commits here last week (no email notification!) Think this is ready to merge now?
Yes, I still think this is a good idea. To be honest, I can't remember what it was that was holding me up from merging this! I think maybe it...