AstroLib.jl icon indicating copy to clipboard operation
AstroLib.jl copied to clipboard

Use more custom types

Open giordano opened this issue 9 years ago • 2 comments

More custom types should be defined and used throughout the package, in order to make it more Julian.

For example, I'd like to use SkyCoords.jl for sky coordinates, but I'd like it first supports entering coordinates with different units, see https://github.com/kbarbary/SkyCoords.jl/issues/6.

giordano avatar Jan 20 '17 22:01 giordano

Out of curiousity, can you give an example of how SkyCoords types with unit parameters would be used in AstroLib?

kbarbary avatar Jan 22 '17 04:01 kbarbary

For example to completely replace gcirc. I don't really like it as it is now (but it closely follows IDL AstroLib's definition). SkyCoords already has the method to compute the distance between coordinates, but lacks the possibility to input coordinates with different units.

giordano avatar Jan 22 '17 12:01 giordano