Krisztian Kasa

> What I would like to understand a bit more is the part about the within group. Why do these changes need to be part of this patch? How are...

>We will make the UDFs skip invalid texts and SUM('text') return NULL. Maybe we will fix GenericUDAFSum. Yes, it seems reasonable because Hive doesn't follow the standard in the case...

@okumin Thanks for the research and sharing the details of your results. I think these are the issues to solve: * as you mentioned: "I believe SUM should return NULL...

@okumin > I believe you mentioned how to correct the following semantics. I will try. Can I resolve it in this ticket? It is ok to file another jira to...

@okumin #5245 was meged to master. Could you please rebase this patch.

In the test [cbo_aggregate_reduce_functions_rule.q](https://github.com/apache/hive/blob/b15ce9126dcc596c953fe202e6834cebdfca6080/ql/src/test/queries/clientpositive/cbo_aggregate_reduce_functions_rule.q#L57-L62) aggregate functions under test (sum, count, stddev*, etc) are wrapped into a `round` function call. I understand the reason however I think it can cause some...

Thanks you guys for the review and merging this patch.

@deniskuzZ Could you please add the jira Id. I haven't found the file `iceberg_partition_stats_with_ppr.q` in the patch

> @kasakrisz let me know if there are pending concerns. Sorry, I was occupied in the last few days. I left only one comment.

> hi @kasakrisz, could you please +1? [apache/calcite#4448](https://github.com/apache/calcite/pull/4448) is already merged. Once it is released, we could try replacing the whole `HiveAggregateReduceFunctionsRule` Currently we have vectorized implementation of the `Sum`...