julien4215

Results 47 comments of julien4215

> One question, does it make sense to have `angle` instead of limited direction values? With angle, I think we are free to do anything. But I agree that it...

Why are Mockito generated files not ignored ? Should I commit them ?

> Please write some unit-tests Done

> With `alignment: Alignment.topLeft and direction: LabelDirection.vertical`, it draws outside of the chart > > But with `alignment: Alignment.topRight and direction: LabelDirection.vertical` it draws inside of the chart. So I...

> I think the vertical one is a bug too. I mean we need to fix both of them. > It would be nice if you can fix them here,...

> I agree that it would be better like this. I'll add a commit to this PR for both of them. Done, it should be ready now.

I am not able to reproduce this bug. Could you give a link to the game or explain or how did you set up an endgame position ?

Not needed anymore. I was able to reproduce and fix the issue.

I don't find the current behavior counter-intuitive personally because you are switching between tabs that have the same importance and that are independent of each other (you can solve a...

Instead of deleting the ModuleVisibility table, the migration file could add all modules in the table ModuleAwarness because all these modules already use visibility