Hyperion icon indicating copy to clipboard operation
Hyperion copied to clipboard

Refactor module visibility to add visibility for new modules

Open armanddidierjean opened this issue 1 year ago • 2 comments

Description

With this PR, modules visibility are stored with a column visible: bool in db.

This allows at startup to add default group ids for new modules, instead of only adding them during the database first initialization

Breaking change: this PR will delete existing Visibilities

armanddidierjean avatar Mar 02 '24 14:03 armanddidierjean

Codecov Report

Attention: Patch coverage is 65.51724% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 80.27%. Comparing base (c82323c) to head (e41c3c9).

:exclamation: Current head e41c3c9 differs from pull request most recent head 7cac715. Consider uploading reports for the commit 7cac715 to get more accurate results

Files Patch % Lines
app/utils/initialization.py 42.85% 8 Missing :warning:
app/app.py 60.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   80.47%   80.27%   -0.20%     
==========================================
  Files          86       86              
  Lines        5766     5774       +8     
==========================================
- Hits         4640     4635       -5     
- Misses       1126     1139      +13     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 02 '24 14:03 codecov[bot]

Instead of deleting the ModuleVisibility table, the migration file could add all modules in the table ModuleAwarness because all these modules already use visibility

julien4215 avatar Apr 29 '24 20:04 julien4215

Is this old PR still relevant after #612 and others PRs by @Rotheem ? Now there's even a front-end UI wherein admins can toggle the visibility for each group and account type and it all works.

Marc-Andrieu avatar Mar 06 '25 10:03 Marc-Andrieu

Completed in https://github.com/aeecleclair/Hyperion/pull/612

armanddidierjean avatar Apr 10 '25 14:04 armanddidierjean