Jukka Palomäki

Results 42 comments of Jukka Palomäki

@machulav Does this look like something you'd like to support? If so, do you want to move in this direction (retaining backwards-compatibility by just adding a new input), or do...

@machulav Looks like we could fix this draft by incorporating the changes from the linked [PR](https://github.com/fac/ec2-github-runner/pull/3)

> Hi @jpalomaki , thanks a lot for the contribution! We tested your fix by running the Github Action from your branch, but we've observed the following: > > *...

@hajapy Have you looked into using [AWS Fleet API](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instant-fleet.html) instead of current `RunInstances`? From what I can tell, Fleet API could also help with https://github.com/machulav/ec2-github-runner/pull/82?

Currently that is true, you can only specify a single security group. I believe this issue could also be solved with #65 (by allowing a user to specify an EC2...

@hajapy Out of curiosity: have you investigated if it'd be possible to use GitHub's job [matrix](https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idstrategymatrix) strategy (which'd just invoke this action several times) to spawn multiple runners?

> However, we would need to introduce v3 with a changed approach to using the action I don't think this is necessarily the case. Launch templates provide _overrideable_ defaults for...

I like simplicity, so that plan for `v3` definitely sounds reasonable. :+1: Consider placing those ideas in a v3 roadmap item or discussion. That said, I do also like backwards-compatibility...

As to the table above, I think #53 (block device mappings, e.g. larger root volume), #3 (tags) and #6 (via instance profile) can also be covered by using a launch...

@machulav Here's a quick CloudFormation template for setting up an EC2 launch template (I'd imagine something like this would help users adopt launch templates): https://gist.github.com/jpalomaki/003c4d173a856cf64c6d35f8869a2de8. Subnet is currently left optional,...