ec2-github-runner icon indicating copy to clipboard operation
ec2-github-runner copied to clipboard
verified publisher icon machulav

Support trying multiple subnets

Open hajapy opened this issue 4 years ago • 3 comments

When AWS is unable to provide an instance in a given availability zone, this action can fail repeatedly (if the condition preventing AWS from having available instances persists). This happens particularly with gpu instance types.

By adding support for multiple subnet ids as input, we can configure the action to try multiple subnets and hence availability zones, giving us a better chance of finding a zone with available instances.

hajapy avatar Dec 01 '21 18:12 hajapy

Would be very appreciated to add! Would love this feature as well!

philschmid avatar Dec 02 '21 16:12 philschmid

@hajapy Have you looked into using AWS Fleet API instead of current RunInstances? From what I can tell, Fleet API could also help with https://github.com/machulav/ec2-github-runner/pull/82?

jpalomaki avatar Jan 07 '22 20:01 jpalomaki

@hajapy Have you looked into using AWS Fleet API instead of current RunInstances? From what I can tell, Fleet API could also help with #82?

@jpalomaki Interesting, no I hadn't considered that, but it seems like it would be a more elegant solution to this and other issues (also providing options for Spot instances, or mixed spot/on-demand). I don't have capacity to work on this, but it is a nice idea.

hajapy avatar Jan 08 '22 17:01 hajapy