Jovan Stojanovic
Jovan Stojanovic
Great! Maybe we should add a small test to check that it all works fine without raising the error?
Oh so it seems that with minimal requirements, ``np.nan == np.nan`` is compared which is ``False`` [by default](https://stackoverflow.com/questions/27616824/python-equality-for-nan-in-a-list) and the test fails. We should find a way to compare the...
> Hi @jovan-stojanovic I'm curious why you went for Countvectorizer (e.g. with character n-grams) instead of, for example, something like the `SimilarityEncoder`. > > I guess the "fuzzy" part comes...
Ok, thanks, working on fixing the tests and will add those changes in a few minutes.
Think I implemented most of your remarks! Please take a look when you have time, we can put it for release 0.3.
> It seems that the test failures that we are witnessing are independent from the PR. @jovan-stojanovic : can you confirm? Yes, this is something that happened for the first...
Apart from the "When is it useful?" part which is too detailed, I find you it's great as it's much clearer. Maybe you can remove/shorten and merge the "When is...
I like what you added to the website! For the part `What can dirty_cat do`, I fear it will have to change often. We have added recently `fuzzy_join` and we...
Hi @mjboos, thanks for opening this PR, exciting work ahead. Just so you know, on Wednesday during the day we plan to have a sprint during which we will take...
Do you think we need a .binder folder [just like in scikit-learn](https://github.com/scikit-learn/scikit-learn/tree/main/.binder), so that the notebooks in the example are well generated? See #380