Joonas Kerttula

Results 39 comments of Joonas Kerttula

@ditman Web does not have example app to verify the clustering functionality. Instead use app-facing package from this PR to test the clustering support on web platform: https://github.com/flutter/packages/pull/4319 And use...

@ditman is it possible to get review for this PR as iOS implementation is already reviewed and Android has only minor test related tasks to do.

@hellohuanlin > can you add some unit tests on native side? Added some native unit tests

> @jokerttu is this ready for re-review? @jmagman not yet, this is waiting new release of Google-Maps-iOS-Utils library to have support latest Google Maps SDK versions. See discussion here: https://github.com/flutter/packages/pull/6186#discussion_r1581115795

> @jokerttu is this still something you're working on? Yes, I am scheduled to work on this issue next week and will update the PR accordingly in the near future....

Note: that the original PR was reviewed at plugins repository at https://github.com/flutter/plugins/pull/6752 Implementation parts have been mainly same, but small fixes and changes has been done to fix conflicts. Web...

@hellohuanlin > @jokerttu is this ready for another review? Not yet, most of the issues @stuartmorgan pointed out are fixed, but there are still few that are not yet done....

@stuartmorgan @ditman I've addressed most of the review comments and made the corresponding updates to the PR (with help of @illuminati1911). However, a few discussions remain open, and I'm actively...

@stuartmorgan > It looks like this still hasn't been split out? The review comments were resolved in this PR before splitting so that the platform-specific implementations would not stretch too...

@stuartmorgan > > However, a few discussions remain open, and I'm actively seeking further input on those. > > Was there anything other than web-specific questions? I looked back through...