packages icon indicating copy to clipboard operation
packages copied to clipboard

[google_maps_flutter] Add marker clustering support - iOS implementation

Open jokerttu opened this issue 1 year ago • 4 comments

This PR introduces support for marker clustering for iOS platform

An example usabe is available in the example application at ./packages/google_maps_flutter/google_maps_flutter_ios/example/ios12 on the page Manage clustering

This is prequel PR for: https://github.com/flutter/packages/pull/4319 and sequel PR for: https://github.com/flutter/packages/pull/6158

Containing only changes to google_maps_flutter_ios package.

Follow up PR will hold the app-facing plugin implementation.

Linked issue: https://github.com/flutter/flutter/issues/26863

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jokerttu avatar Feb 23 '24 14:02 jokerttu

@hellohuanlin

can you add some unit tests on native side?

Added some native unit tests

jokerttu avatar Apr 03 '24 12:04 jokerttu

@jokerttu is this ready for re-review?

jmagman avatar May 08 '24 21:05 jmagman

@jokerttu is this ready for re-review?

@jmagman not yet, this is waiting new release of Google-Maps-iOS-Utils library to have support latest Google Maps SDK versions. See discussion here: https://github.com/flutter/packages/pull/6186#discussion_r1581115795

jokerttu avatar May 13 '24 09:05 jokerttu

FYI I have raised the blocking issue internally with the Google Maps team.

stuartmorgan-g avatar May 15 '24 14:05 stuartmorgan-g

Update from triage: I haven't heard anything yet on when the utils SDK will be usable for us.

stuartmorgan-g avatar Jul 09 '24 19:07 stuartmorgan-g

It looks like the iOS utils pod might be updated enough to land this. Worth checking out: https://github.com/googlemaps/google-maps-ios-utils/issues/473#issuecomment-2261690953

Rexios80 avatar Aug 01 '24 00:08 Rexios80

As version 5.0.0 and version 6.0.0 for Google-Maps-iOS-Utils has been published, I am able to continue with this. Meanwhile the package has been migrated to pigeon, so this needs now a bit more changes than version number...

jokerttu avatar Aug 02 '24 06:08 jokerttu

@stuartmorgan this is again ready for review.

Updated version dependency for Google-Maps-iOS-Utils: s.dependency 'Google-Maps-iOS-Utils', '>= 5.0.0', '< 7.0.0' ios14 uses version 5.0.0 for GoogleMaps Sdk version 8.x ios15 uses version 6.0.0 for GoogleMaps Sdk version 9.x

Migrated to pigeon messaging

jokerttu avatar Aug 02 '24 12:08 jokerttu

@stuartmorgan Fixed the issues mentioned in the review. Rebased and fixed conflicts with heatmap support.

jokerttu avatar Aug 06 '24 18:08 jokerttu

auto label is removed for flutter/packages/6186, due to This PR has not met approval requirements for merging. Changes were requested by {stuartmorgan}, please make the needed changes and resubmit this PR. The PR author is a member of flutter-hackers and needs 0 more review(s) in order to merge this PR.

  • Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

auto-submit[bot] avatar Aug 06 '24 19:08 auto-submit[bot]

@stuartmorgan seems like I need separate approval from you before I can add autosubmit label.

jokerttu avatar Aug 06 '24 19:08 jokerttu