John Kuhn

Results 16 comments of John Kuhn

Same for me. Perhaps a stale issue. Going to close:

There were two potential issues: 1. the readme example excluded the `http://` which would break if copied 2. github enterprise accounts have to set a value, which shouldn't be required...

@nimi73 can you share the link to your repo (if public)? Or the workflow yml file contents so I can help debug?

> I stopped using this action, its too unstable and prone to breaking. @lukehinds Take a look at the latest version `v.1.10.0`. I thought the same thing about the project...

Closing as it's been addressed by #71

Love this idea! Agreed. At least providing an option like `ignore_deletions: false` which is false by default

This change takes the wildcard matching and switches us to regex matching. Both are acceptable options. As a point of opinion, wildcard matching feels more ergonomic. If we did want...

#71 may have corrected this problem. The config value needed to be expanded as a whitespace separated list, done here https://github.com/CodelyTV/pr-size-labeler/pull/71/files#diff-d7c80f5e143a779b6ea480fe7455d4ba2934ccd1b453062355c72f000c9e7d02R15 Now the action logic matches the unit tests. I'll...