pr-size-labeler icon indicating copy to clipboard operation
pr-size-labeler copied to clipboard

fix: regex pattern matching

Open kounoike opened this issue 2 years ago • 2 comments

#50 didn't fix #38. because [[ "abc" == $pattern ]] is simple string match. for regex match, should be [[ "abc" =~ $pattern ]].

this PR fix it.

this PR also fix document. ignore pattern is regex, NOT glob.

kounoike avatar Nov 09 '23 05:11 kounoike

This change takes the wildcard matching and switches us to regex matching. Both are acceptable options. As a point of opinion, wildcard matching feels more ergonomic.

If we did want to support regex matching, maybe this should be another param like regex_files_to_ignore?

johnlk avatar Apr 15 '24 14:04 johnlk