Jonathan

Results 7 comments of Jonathan

Few annotations i'm bumping as a reminder: - https://github.com/Crossmint/crossmint-sdk/pull/660#discussion_r1719103468 - https://github.com/Crossmint/crossmint-sdk/pull/660#discussion_r1719102923 - https://github.com/Crossmint/crossmint-sdk/pull/660#discussion_r1718960995

> I'm testing it with other apps. So far, in Smarter Wallet, there are some styles that are not being built correctly so I'm looking into it. > > @jmderby...

> yeah, classes like `border-[${appearance.colors.border}]` are known to not work/be flaky > > better to use style object for those Yeah, I'm looking at safelisting (https://tailwindcss.com/docs/content-configuration#safelisting-classes) but it seems like...

@maxwellfortney @AlbertoElias do you guys want me to prioritize a PR that replaces dynam classes with inline asap?

Closing due to the changes needing to be apart of https://github.com/Crossmint/crossmint-sdk/pull/794 because we need to calculate the height based on the number of `loginOptions` from that PR.

Closing. Going with a different approach.

build is failing due to tests but doesn't seem to be related to these changes