crossmint-sdk icon indicating copy to clipboard operation
crossmint-sdk copied to clipboard

Auth modal: Responsive height

Open jmderby opened this issue 1 year ago • 2 comments

Description

Now that we're adding more loginOptions, we need the modal to respond to the different heights. I was able to achieve this simply by using our existing strategy from embedded checkouts. This ticket relys on a PR from main repo

Photos to showcase different permutations/combos

Screenshot 2024-10-03 at 4 05 15 PM Screenshot 2024-10-03 at 4 06 56 PM Screenshot 2024-10-03 at 4 07 16 PM Screenshot 2024-10-03 at 4 08 58 PM Screenshot 2024-10-03 at 4 09 31 PM

Test plan

Tested through flow and everything still works, also tested different combinations.

Package updates

@crossmint/client-sdk-react-ui

jmderby avatar Oct 03 '24 23:10 jmderby

⚠️ No Changeset found

Latest commit: 5ccf0081e14332fee8b9cc793ddef7cdbb2e49d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 03 '24 23:10 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
smart-wallet-auth-demo ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 4:48pm

vercel[bot] avatar Oct 03 '24 23:10 vercel[bot]

Closing due to the changes needing to be apart of https://github.com/Crossmint/crossmint-sdk/pull/794 because we need to calculate the height based on the number of loginOptions from that PR.

jmderby avatar Oct 09 '24 16:10 jmderby