Justin Lebar
Justin Lebar
I don't know of anyone on the MemShrink team who speaks a foreign language, although I've never asked. If we're all unilingual anglophones, I guess it should be listed under...
Oh. :) C++ is the only language with significant relevance.
Hi, thanks for getting back to me so quickly! > I'm primarily a Python developer Heh, I am primarily a C++ developer, so we're off to a great start here....
@kaixih This is great -- thank you for this PR! Are you planning to hook this into XLA (tensorflow/compiler/xla/service/gpu/cudnn_fused_conv_rewriter.h), or should we work on that?
> Thanks. As for the XLA, our XLA team is working on a generic conv fusion support but it would take some time. For this special pattern, if needed, we...
@reedwm this is ready to submit. Thanks for helping with this.
> we should know how to replay them back into the system, or how to use them in manual tests of some sort? No ability to do this at the...
Now that I read this closely and understand... This is exactly what gmock is for. Instead of having `test_setAnalogPin`, you make analogRead() a mock method, and then you can make...
I see now -- I totally agree that would be a too-tightly-coupled test strategy. analogRead should be side-effect-free. Sorry for the noise.