Justin Lebar

Results 95 comments of Justin Lebar

I would prefer that we always do the non-generic printing. We have lots of pretty-printers. It seems like there's a bug where axis=0 isn't handled correctly or something and we...

``` if x > y: # x and y are tensors return ``` It seems like the Triton frontend should raise an error if you write this Python code, and...

Hey, Aliia. :) I don't understand this patch. ``` // TODO: remove s8xf32 matmul special case when issue is fixed. // https://github.com/openai/triton/issues/2853 ``` What do you mean by this TODO?...

> that’s why I had to separate the test case WDYM by this? I see a testcase in this PR -- I assume this testcase fails or crashes without your...

Closing due to inactivity after https://github.com/openai/triton/pull/3018#discussion_r1484578212. @gflegar feel free to send a patch that takes this comment into account if you want to reopen this -- I do get the...

Looks like pre-commits are failing.

Eh, I can approve as-is, you are capable of fixing that stuff. :)

@Artem-B is this a bug in the nvptx backend's legalization routine?

Thank you for the patch! I'm going to run CI before approving this, just to check that it works.