John K Watson comments

Results 14 comments of


                                            John K Watson

[VUMM-297] Move artifact store to common module

This looks generally ok. If we want to save testing until later, that's ok, but we should create an issue to track it.

[VUMM-297] Move artifact store to common module

This PR is gigantic, and to my eyes, includes functional changes with no tests for them. I don't want to merge this without testing on the new functionality.

[VUMM-297] Move artifact store to common module

> @jkwatson-verta I have already added many test cases but it is not feasible to run it with automation so I have disabled it or either not added in test...

[VUMM-297] Move artifact store to common module

Since the Jira ticket has no reason as to why this change is being made, can you add some description to the PR itself, so I can understand why this...

chore: [VUMM-392] Add InternalFuture with default Executor

This is looking pretty good. I'd add some unit tests for the new functionality. I'm not 100% sure how to verify that the proper executor is being used... maybe with...