modeldb icon indicating copy to clipboard operation
modeldb copied to clipboard

[VR-13069] Make ModelDB build to Postgres compatible

Open anandjakhaniya opened this issue 4 years ago • 4 comments

Impact and Context

Jira Ticket: https://vertaai.atlassian.net/browse/VR-13069

  • Make MDB backend to compatible with Postgres and fix Liquibase tags according to the same as well.

Note:

  • Please replace RdbDialect from org.hibernate.dialect.PostgreSQLDialect into org.hibernate.dialect.PostgreSQL82Dialect to successfully execute MDB service with postgres. Old dialect was deprecated.
  • New DB config should like
database:
  DBType: relational
  timeout: 4
  liquibaseLockThreshold: 60
  RdbConfiguration:
    RdbDatabaseName: modeldb_oss
    RdbDriver: "org.postgresql.Driver"
    RdbDialect: "org.hibernate.dialect.PostgreSQL82Dialect"
    RdbUrl: "jdbc:postgresql://localhost:5432"
    RdbUsername: postgres
    RdbPassword: root

Risks

Testing

  • [ ] Deployed the service to dev env
  • [ ] Used functionality on dev env
  • [ ] Added unit test(s)
  • [ ] Added integration test(s)

How to Revert

anandjakhaniya avatar Sep 30 '21 13:09 anandjakhaniya

Please regression test against existing mysql databases to ensure successful migration and no hash mismatches

coryverta avatar Sep 30 '21 16:09 coryverta

Please update the backend/config.yaml and backend/config.example.yaml

Added sample oss-config.yaml in repo

anandjakhaniya avatar Oct 01 '21 17:10 anandjakhaniya

This is too much old code and seems like now it is not useful. Also, the Jira ticket is marked as incompleted https://vertaai.atlassian.net/browse/VR-13069 so closing this PR.

anandjakhaniya avatar Jul 19 '22 03:07 anandjakhaniya

This is too much old code and seems like now it is not useful. Also, the Jira ticket is marked as incompleted https://vertaai.atlassian.net/browse/VR-13069 so closing this PR.

I have reopened. I feel like it is still useful so investigating more on this.

anandjakhaniya avatar Jul 19 '22 04:07 anandjakhaniya

closing as this is quite out of date

jkwatson-verta avatar Apr 05 '23 23:04 jkwatson-verta