jjparkcv

Hi, thank for sharing such a great dataset! I was looking at the depth map upsampling task introduced by this dataset. However, I'm thinking that the current resolution of the...

filter_parameters not being set?

7

Hi, I'm trying to find out which cutoff frequencies you actually used for you experiments. So, I tried to find where is the function 'filter_parameters' is being used, but I...

Hi Luke, thank you for sharing this amazing work. In your [arxiv document](https://arxiv.org/pdf/2105.02723.pdf), I cannot find any mention of positional encoding, but I see that you use them in your...

Normalize rays_d

7

Hi, thank you for sharing a good codebase. In https://github.com/yenchenlin/nerf-pytorch/blob/a15fd7cb363e93f933012fd1f1ad5395302f63a4/run_nerf_helpers.py#L159 you are using an unnormalized "rays_d" Shouldn't this be normalized so that it indicates a direction vector? Thanks in advance.