James Groffen

Results 14 comments of James Groffen

Hello @elazarl, I hit the same problem and agree with @dmjones, the reason handlers receive AND return the request object is to give handlers an opportunity to change the request,...

Hello @elazarl, sorry about the delay in responding, Also I must apologise as my example has a mistake in it. The issue is with `filterRequest` in proxy.go, so my example...

I need this as well - GitLab is showing top level groups to users that don't have priv to see them, but then returning a 404. Privs are correct and...

Hello @nathanparekh, I have submitted a patch (#119) to determine the ADDRESS automatically if one is not provided. Makes deployment to Heroku and many other situations easier. The documentation updates...

Can confirm same issue when deploying to Heroku. A workaround is, in the Heroku deployed CrewLink Server: - Go to the settings tab - Press 'Reveal Config Vars' button -...

Hello @nathanparekh - I just checked too and agree, looks like it's only used to render the HTML or JSON queries to the web service. The HTTP response could check...

@nathanparekh Agreed - that is what I'm proposing - and as you say, add the info log output when it is defaulted.

Hello @nathanparekh > Heroku provides a PORT environment variable that applications are supposed to bind their HTTP servers to, and it seems like they serve as a reverse proxy Yeah...

Resolves #116 and #117 (edit: and now #130) #118 submitted by @nathanparekh does a good job of improving documentation but would need to be tweaked a bit if this PR...

I have tested this extensively, in Heroku only. Heroku is now back to deploying simply and working straight from the 'Deploy to Heroku' button only. The `/health` endpoint also behaves...