CrewLink-server icon indicating copy to clipboard operation
CrewLink-server copied to clipboard

Update instructions given the new ADDRESS requirement

Open nathanparekh opened this issue 5 years ago • 1 comments

Updates the readme to show in the instructions how to setup and use the newly required ADDRESS environment variable. As discussed in #116 there might be some better ways to handle this overall, but in the meantime the instructions should be updated so that people aren’t confused.

For quick reference: For Heroku, people currently need to deploy and then go to the app settings and set ADDRESS to their Heroku app url. For Docker, it needs to be set using -e or by modifying the Dockerfile. For Node, set manually.

Closes #117

nathanparekh avatar Dec 28 '20 00:12 nathanparekh

Hello @nathanparekh,

I have submitted a patch (#119) to determine the ADDRESS automatically if one is not provided. Makes deployment to Heroku and many other situations easier.

The documentation updates you have made here are very good - but if my patch is accepted the updates in this PR will need adjusting.

Cheers,

jgroffen avatar Dec 28 '20 06:12 jgroffen