Jean-Francois Remy

Results 7 issues of Jean-Francois Remy

The logic when overwriting a file seems wrong. If you look at the code path, if clobber is true and modified is false, then there will be a systematic call...

With ejs 2.x, compound stops working. The reason is that the current code assumes the render engine is synchronous and calls next after making its last render call. This is...

It's not possible to set a specific "use" method for the noip provider. If my config is for instance use=if, if=igc0, \\ protocol=dyndns2, \\ server=dynupdate.no-ip.com, \\ login=username, \\ password=password \\...

The SetAttribute* methods are supposed to return the considered attribute (new or existing) However, because of the variable shadowing in the creation path, it does not return the new Attribute...

The `CreateOrPatch` code directly exits after creating an object, it does not consider whether the status was modified or not. This means that any change made to the status will...

cncf-cla: yes
size/M
do-not-merge/hold
lifecycle/rotten
needs-ok-to-test

When using the `CreateOrPatch` or `CreateOrUpdate` methods, the status of the object won't be persisted if the object does not exist. In both functions: - https://github.com/kubernetes-sigs/controller-runtime/blob/v0.16.3/pkg/controller/controllerutil/controllerutil.go#L247 - https://github.com/kubernetes-sigs/controller-runtime/blob/v0.16.3/pkg/controller/controllerutil/controllerutil.go#L208 The method...

kind/support
lifecycle/rotten

**Describe the feature request** The AuthorizationPolicy spec (security/v1beta1/authorization_policy.pb.go) go type can't be used with controller-tools If I try to create a CRD with kubebuilder / controller-tools that embeds an AuthorizationPolicy...

kind/enhancement