Jean-Francois Remy

Results 15 comments of Jean-Francois Remy

For those interested I have an updated version that so far seems to be working fine with express 4. It's at https://github.com/jfremy/compound/tree/express4. The only thing I had to modify was...

My express 4 branch has a fix for compound or you can check my pull request to compound that contains only the fix. https://github.com/1602/compound/pull/646 The issue is that render was...

sorry for the delay but cached js/css bugfix is in

In the case of `CreateOrUpdate`, it actually never update the status so one could argue, it just needs to be documented. But `CreateOrPatch` does update the status if the object...

> /kind support > > I’m wondering if this is by design. When creating an object with the client.Client, the status doesn’t get persisted because it doesn’t use a `SubResourceClient`...

> /kind support > > I’m wondering if this is by design. When creating an object with the client.Client, the status doesn’t get persisted because it doesn’t use a `SubResourceClient`...

Quote from the “documentation” from CreateOrPatch: ``` CreateOrPatch creates or patches the given object in the Kubernetes cluster. The object's desired state must be reconciled with the before state inside...

`CreateOrUpdate` won’t update the Status ever. That was incorrect in my initial statement. It will only ever update the resource but not the sub resource. `CreateOrPatch` behaves differently from `CreateOrUpdate`...

The `CreateOrUpdate` code is essentially: ``` - get object - if does not exist, run mutate and create with object after mutate - if exists, run mutate, check if there...

I definitely agree `CreateOrUpdate` should be left as is - probably worth adding a note stating it does not touch the status