Jenn Nguyen
Jenn Nguyen
This PR needs a release from `gz-gui6` but I'm waiting until the plotting PR is ready and merged (ref: https://github.com/gazebosim/gz-sim/pull/1571#issuecomment-1190430491)
This is looking good @AzulRadio but requires a `gz-gui3` release before it can be merged. It would be nice to get https://github.com/gazebosim/gz-gui/pull/466 in before then so I'll take over this...
Moving this to TODO to focus on the Garden release. `GzPose` will need some additional updates so we don't have recession of functionality (eg., spinbox min/max values for each element)
Thanks @ahcorde for taking a look. I was playing around during the sim meeting and in: https://github.com/gazebosim/gz-rendering/blob/1481bf8e2856a2e29fa2592bd4c32951e09166e9/ogre2/src/Ogre2Camera.cc#L79 If you change `this->aspect` to `this->AspectRatio()` the crash no longer happens for me...
> I added more guards against NaNs in the following PR, maybe it helps with your crash? > https://github.com/gazebosim/gz-rendering/pull/655 Unfortunately, I'm still getting the crash on Focal and Bionic :confused:
> I'd appreciate it if someone could check if that solves the crashes for them. Thanks for the attempt but unfortunately I'm still getting crashes :(
Closing until https://github.com/gazebosim/gz-rendering/issues/710 is resolved
Some issues I've found: - Same as comment https://github.com/gazebosim/gz-sim/pull/1464#issuecomment-1138946824 - When using the resource spawner, the sim freezes while the item is being loaded and am not able to interact...
> maybe you can feel some issues when the model is loaded in rendering but it's something which is not targeting this PR. Can you please clarify?
> /// \todo(anyone) Move to GuiRunner::Implementation when porting to v5 https://github.com/gazebosim/gz-sim/blob/c52e1405713c04e72859c4e8031ed153348d233f/src/gui/GuiRunner.hh#L78 The `todo` comment will be removed in https://github.com/gazebosim/gz-sim/pull/1678