Jeldrik Hanschke

validateConfirmation does not revalidate if related property changes

1

## Version 1.2.8 ## Test Case https://ember-twiddle.com/8687b828162c979dceef152ba69d1be8?openFiles=controllers.application.js%2C ## Steps to reproduce Enter missing "t" in "Password" input field. ## Expected Behavior Password confirmation should be valid after both values are...

This special code for update breaks update. Reduced to update function of Chart.Bar.js (https://github.com/nnnick/Chart.js/blob/6507f5c0872705c7853dd5a0a6d112ea9d843e7e/src/Chart.Bar.js#L144-L155) and everything works fine.

I noticed that some adopted ember addons have a custom deployment step at the end of their pipeline: - ember-autoresize: https://github.com/adopted-ember-addons/ember-autoresize/blob/e1d172f69c89772a5d48dabf340335e932a09619/.travis.yml#L47-L50 - ember-collapsile-panel: https://github.com/adopted-ember-addons/ember-collapsible-panel/blob/e6bc55477761df5d57de5981c9d97c5ffb5c632c/.travis.yml#L33-L40 This is a similar use case...

I noticed that some adopted addons, which are not yet migrated to GitHub Actions, added code coverage checks to their TravisCI pipeline. Would be great if we could support this...

Some repositories seem to have a mismatch between the package manager used in TravisCI configuration (`.travis-ci.yml`) and the lock file committed to the repository. @simonihmig reported this issue when migrating...

An interactive mode driving users through CI creation would be great. Currently it's too much magic without feedback and manual intervention in my perspective. This could be done using a...

Ember CLI changed the format used in TravisCI configuration file with its v3.4.0 release. Some addons still use the format generated by Ember CLI

Support arbitary environment variables in job configuration

1

So far only `EMBER_CLI_SCENARIO` environment variable is extracted from `.travis.yml` configuration and used to generate the GitHub Action CI: https://github.com/jelhan/create-github-actions-setup-for-ember-addon/blob/e518896b9bed309ae419736f4e8f57d76cfa0c69/src/utils/parse-travis-ci-config.ts#L65-L74 https://github.com/jelhan/create-github-actions-setup-for-ember-addon/blob/e518896b9bed309ae419736f4e8f57d76cfa0c69/templates/.github/workflows/ci.yml#L204-L207 It should be possible to migrate every environment variable...

In #13 it was proposed to not cache both package manager's global cache and `node_modules` but only one of them. @simonihmig proposed to cache only package manager's global cache: >...

Ember CLI blueprints doesn't had `lint` and `test:ember` scripts before 3.18: https://github.com/ember-cli/ember-addon-output/commit/0be9a366b7e75a7f724c489ef9a2ada90e15802b But created workflow rely on them being present. One solution would be adding that script to `package.json` and...