Jeldrik Hanschke

Results 427 comments of Jeldrik Hanschke

Why do you unset $tp[ip] on line 36? Just a few lines later (l. 43) value is overwritten with new timestamp.

I'm facing the same bug. For some reason I missed this GitHub issue when scanning over reported bugs. I came up with another reproduction, which shows the same: https://github.com/jelhan/reproduce-invalid-change-in-ember-changeset-if-used-together-with-ember-bootstrap-power-select To...

I debugged a little bit further. Let me share my findings. Hopefully they are helpful for other to debug further. All findings use my reproduction given above. 1. `this[CHANGES]` contains...

> Since submitting this issue, a co-worker has pointed out to me this section of the README: https://github.com/poteto/ember-changeset#changeset-template-helpers I wonder if this is the reason and/or related to why they...

@snewcomer Thanks a lot for implementing the date validator in #218. Can't count how often I have implemented something like this in app space. I should have pushed one of...

> Creating dates with a string is a source of error if the string doesn't contain time information. You could also see it the other way around: Information about the...

I understand your concerns but to be honest I think most of them are caused by relying on `Date` objects rather than using ISO8601 strings. I think this could be...

> I'm not sure we need to only limit to ISO8601 either Not limiting to a subset of ISO 8601 opens up a wide range of edge cases. The spec...

> Lmk if you would like me to take it on! I got some time this week. This would be awesome. I'm totally overloaded with Open Source stuff currently. :cry:

@steveszc Make sense. But wondering if this is needed on all validators. Or is `date` validator a special case?