Jean Pierre

Results 125 comments of Jean Pierre

@Tyriar I started playing around with the renderer and I think I fixed this and some tranparency issue in #3349, would be great it you could try it out

When I worked on this, I installed powerline10k to do some tests and from what I understood the way they handle the powerline glyphs is by manually adding a space...

> Furthermore the fact that this issue exists tells me, that the shell currently does not add those whitespaces. This issue is specific to the webgl renderer (there's some logic...

> So do you think creating another hack to work around the existing whitespace hack is good practice? Oh, no, not at all, in fact in my PR I removed...

@Tyriar With the tests I've done so far it seems to be working fine. Do you know some edge cases that I could test? master | fix with measure text...

ah but that's also present in the master branch with the trimming logic: ![image](https://user-images.githubusercontent.com/25115070/120527714-47b28e80-c3a0-11eb-8d21-d0abd551e571.png) And in the native terminal too (I'm in ubuntu) using different fonts: ![Screenshot from 2021-06-02 12-35-33](https://user-images.githubusercontent.com/25115070/120527938-87797600-c3a0-11eb-8f3f-e07477b75f62.png)...

Even after rolling back I see some request failing, specifically requesting web extension resources e.g. vim extension is failing to load https://open-vsx.org/vscode/asset/vscodevim/vim/1.23.1/Microsoft.VisualStudio.Code.WebResources/extension/out/extensionWeb.js

> That's great, but the workspace is still not opened. I get an error message which says Failed to connect to the remote extension host server (Error: Connection error: Unauthorized...

@axonasif you need to sync the uninstallation first i.e. remove them from `settingsSync.ignoredExtensions` and then uninstall so they are removed from the sync server, then if you want to only...