Junaid comments

Results 138 comments of


                                            Junaid

fix(web3-errors): the undefined data in Eip838ExecutionError

cc: @mconnelly8

fix(web3-errors): the undefined data in Eip838ExecutionError

this PR will be merged into 4.x via: [web3:junaid/eip838fix](https://github.com/web3/web3.js/tree/junaid/eip838fix)

WebSocket connection to Ethereum node closes/becomes idle after some time and reconnection fails to listen to smart contract events

cc: @mconnelly8 @luu-alex should this be in docs?

Update index.md

@SantiagoDevRel changes mentioned in this PR should be merged via new PR created by you.

Update quickstart.md

@SantiagoDevRel changes mentioned in this PR should be merged via new PR created by you.

The from address changes when the transaction gets signed and hashed.

@zurikdev I saw you are using `web3.eth.sign(sha3_, target)` for signing. `target` address in above call will be used for signing regardless what from you specify in your transaction in above...

E2E Infura Tests update

investigate and fix blackbox tests as part of this issue

Create a function `revokeAccess` that disconnects any previously connected wallets

We discussed this in team meeting, and agreed on : instead of supporting `wallet_revokePermissions` only, we should add support of list of common wallet rpc functions like: `wallet_addEthereumChain` , `wallet_switchEthereumChain`,...