web3.js icon indicating copy to clipboard operation
web3.js copied to clipboard

Update quickstart.md

Open mrezabidhendi opened this issue 1 year ago • 1 comments

The Variable ABI was defined in all CAPS, but it was used in the function call in all lowercase which lead to error.

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have selected the correct base branch.
  • [x] I have performed a self-review of my own code.
  • [ ] I have commented my code, particularly in hard-to-understand areas.
  • [x] I have made corresponding changes to the documentation.
  • [x] My changes generate no new warnings.
  • [ ] Any dependent changes have been merged and published in downstream modules.
  • [ ] I ran npm run lint with success and extended the tests and types if necessary.
  • [ ] I ran npm run test:unit with success.
  • [ ] I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • [ ] I ran npm run build and tested dist/web3.min.js in a browser.
  • [ ] I have tested my code on the live network.
  • [ ] I have checked the Deploy Preview and it looks correct.
  • [ ] I have updated the CHANGELOG.md file in the root folder.
  • [ ] I have linked Issue(s) with this PR in "Linked Issues" menu.

mrezabidhendi avatar Jun 09 '24 08:06 mrezabidhendi

Thank you for catching this! I think it would actually be better to change the variable name to lowercase.

danforbes avatar Jun 10 '24 14:06 danforbes

@SantiagoDevRel changes mentioned in this PR should be merged via new PR created by you.

jdevcs avatar Jul 01 '24 12:07 jdevcs