fix(web3-errors): the undefined data in Eip838ExecutionError
Description
Fixes #6433
process the undefined data in Eip838ExecutionError constructor to avoid an "read something from undefined" bug.
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Checklist:
- [x] I have selected the correct base branch.
- [x] I have performed a self-review of my own code.
- [x] I have commented my code, particularly in hard-to-understand areas.
- [x] I have made corresponding changes to the documentation.
- [x] My changes generate no new warnings.
- [x] Any dependent changes have been merged and published in downstream modules.
- [x] I ran
npm run lintwith success and extended the tests and types if necessary. - [x] I ran
npm run test:unitwith success. - [x] I ran
npm run test:coverageand my test cases cover all the lines and branches of the added code. - [x] I ran
npm run buildand testeddist/web3.min.jsin a browser. - [ ] I have tested my code on the live network.
- [ ] I have checked the Deploy Preview and it looks correct.
- [ ] I have updated the
CHANGELOG.mdfile in the root folder. - [x] I have linked Issue(s) with this PR in "Linked Issues" menu.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.99%. Comparing base (
4358140) to head (b9c6117). Report is 273 commits behind head on 4.x.
:exclamation: Current head b9c6117 differs from pull request most recent head 933acc2
Please upload reports for the commit 933acc2 to get more accurate results.
Additional details and impacted files
@@ Coverage Diff @@
## 4.x #6905 +/- ##
==========================================
+ Coverage 87.37% 91.99% +4.62%
==========================================
Files 197 215 +18
Lines 7548 8172 +624
Branches 2059 2202 +143
==========================================
+ Hits 6595 7518 +923
+ Misses 953 654 -299
| Flag | Coverage Δ | |
|---|---|---|
| UnitTests | 91.99% <100.00%> (+4.62%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| web3 | ∅ <ø> (∅) |
|
| web3-core | ∅ <ø> (∅) |
|
| web3-errors | ∅ <ø> (∅) |
|
| web3-eth | ∅ <ø> (∅) |
|
| web3-eth-abi | ∅ <ø> (∅) |
|
| web3-eth-accounts | ∅ <ø> (∅) |
|
| web3-eth-contract | ∅ <ø> (∅) |
|
| web3-eth-ens | ∅ <ø> (∅) |
|
| web3-eth-iban | ∅ <ø> (∅) |
|
| web3-eth-personal | ∅ <ø> (∅) |
|
| web3-net | ∅ <ø> (∅) |
|
| web3-providers-http | ∅ <ø> (∅) |
|
| web3-providers-ipc | ∅ <ø> (∅) |
|
| web3-providers-ws | ∅ <ø> (∅) |
|
| web3-rpc-methods | ∅ <ø> (∅) |
|
| web3-utils | ∅ <ø> (∅) |
|
| web3-validator | ∅ <ø> (∅) |
@Muhammad-Altabba could you update changelog and merge this PR, as seems @Alfxjx is away.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.
cc: @mconnelly8
this PR will be merged into 4.x via: web3:junaid/eip838fix