Joshua Cranmer

Results 10 comments of Joshua Cranmer

Let me run through some of the basic stuff I do with the SYCL compilation. If you run `dpcpp -S example.cpp`, you get a bundled .s file that looks like...

Running `llvm-spirv --spirv-tools-dis` will convert an LLVM bitcode file into a textual SPIR-V file, but it requires `llvm-spirv` to be compiled with the spirv-tools. I don't believe this is accessible...

I've tried some test changes with this run, but I have noticed a few issues. For example, one test generated this: ``` %call1.i.i.i = call spir_func ptr addrspace(1) @_Z20__spirv_SampledImageI14ocl_image1d_ro32__spirv_SampledImage__image1d_roET0_T_11ocl_sampler(ptr addrspace(1)...

SYCL/Basic/image/image_sample.cpp is the test I think I was seeing that particular line on.

There's still a clutch of errors I see with regards to other OpenCL types (pipe tests are the next set of ones I see, IIRC)--it feels like it's going to...

> Do you plan to handle ESIMD types separately? Fixing ESIMD types hasn't been on my roadmap: I've been focusing on eliminating opaque pointer stuff in the llvm-spirv translator, where...

> Functionally LGTM Do I understand correctly, that the commit flow would be looking like: merge this patch -> adjust RegularizeLLVM pass in the translator (removing the nasty processing of...

Ping @intel/llvm-reviewers-runtime for review, since you're apparently a codeowner for the last test change?

Some drive-by comments: * canonicalize(SNAN) needs to raise the INVALID floating point exception * it's a should, not a must requirement, but the corresponding quiet NaN should have the same...