llvm icon indicating copy to clipboard operation
llvm copied to clipboard

[SYCL][SPIR-V] Change the LLVM type name of SPIR-V matrix types.

Open jcranmer-intel opened this issue 3 years ago • 1 comments

This eliminates the need for the SPIR-V translator to query the pointer element type of the members in the struct to figure out what matrix type it really is.

jcranmer-intel avatar Aug 05 '22 21:08 jcranmer-intel

Do you plan to handle ESIMD types separately?

Fixing ESIMD types hasn't been on my roadmap: I've been focusing on eliminating opaque pointer stuff in the llvm-spirv translator, where ESIMD types aren't involved.

jcranmer-intel avatar Aug 08 '22 20:08 jcranmer-intel

Friendly rereview request ping?

jcranmer-intel avatar Aug 19 '22 19:08 jcranmer-intel

Functionally LGTM Do I understand correctly, that the commit flow would be looking like: merge this patch -> adjust RegularizeLLVM pass in the translator (removing the nasty processing of an array W/A) -> remove nasty array W/A in SYCL headers ?

Yes.

jcranmer-intel avatar Aug 24 '22 20:08 jcranmer-intel

Ping @intel/llvm-reviewers-runtime for review, since you're apparently a codeowner for the last test change?

jcranmer-intel avatar Aug 26 '22 15:08 jcranmer-intel

@intel/llvm-gatekeepers this one looks ready.

aelovikov-intel avatar Aug 26 '22 16:08 aelovikov-intel