Justin Bousquin

Results 52 comments of Justin Bousquin

Looks like those nbviewer links are hardcoded directly in the [index.rst](https://github.com/pysal/tobler/blob/main/docs/index.rst) (lines ~13, 21, 29, so just a link update?). For the docs [tutorial page](https://pysal.org/tobler/tutorial.html), [tutorial.rst](https://github.com/pysal/tobler/blob/main/docs/tutorial.rst) is pointing to the...

Thanks @isabelizimm - made those suggested changes on [pyOpenSci-review](https://github.com/USEPA/harmonize-wq/tree/pyOpenSci-review) branch. Let me know if there is anything else while we wait.

Thanks @Batalex. No questions so far, let me know if anything comes up.

Thanks @rcaneill! Let me know as things come up :)

I'll start addressing these on a pyOpenSciReview branch (I'll try to be better about merging to main so other reviewers aren't running into the same things). Will generate a issue...

@Batalex fixing issue (general): circular dependencies - will be a breaking change. To resolve I moved functions from harmonize, df_checks()/add_qa_flag() to clean, convert_unit_series() to convert and units_dimension() to wq_data (to...

Hey @Batalex - that works for me. I've already been working through issues/suggestions as received/as I can.

Hey @Batalex - yes a couple PRs in the pipeline I need to check tutorials on but had to back-burner with the holiday and field season coming up. Hoping to...

Hello @Batalex, Apologies - I was hoping to have gotten the tutorials checked against changes and summaries of changes/responses copied over here before getting buried in field work in June....

Hey @Jacque-123, Thanks again for your review. Several changes over on the package repo I wanted to draw your attention to/**responses** to _comments_: _1. Harmonize_Pensacola.Rmd: -Small language changes suggested to...