Justin Bousquin
Justin Bousquin
> If adding example data should that be as part of the same commit or split into it's own? We'll want to be sure that updated data gets tested in...
From what I can tell right now the loop just keeps going until an empty response comes back (so at least one more than it needs to). Might be worth...
looks like arcgislayers package is being used in fetchNHD()... @mhweber - I used to use NHDplusTools or something like that to get NHD but I feel like there has been...
Looks like httr not httr2 is being used - is that consistent throughout TADA?
Looks like httr2 includes built-in support for features like rate-limiting ([req_throttle()](https://httr2.r-lib.org/reference/req_throttle.html)) if this ends up having to go that route.
[Utilities::TADA_CheckColumns()](https://github.com/USEPA/EPATADA/blob/develop/R/Utilities.R#L221) seems like it could be leveraged for the spatial cols checks in these functions - everyone OK with me updating those (just going to add arg for non-default message...
Heads: was getting a consistent 500 Internal Server Error from dataRetrieval::getWebServiceData(baseURL) when trying to use the fetchATTAINS() example data: ``` tada_data
As I go I'm realizing the query exit condition is nested meaning it's rarely just 1 extra query to get an empty response, rather it is when all responses from...
From what I can tell there are three things that could impact stability, all related to use of TADA_RandomTestingData(): 1) There are two versions of the function TADA_RandomTestingData, one in...
I noticed some file cache-ing, maybe a function to parse the query string back out and save there in a way that could easily then be unpacked to run the...