Jordi Baylina
Jordi Baylina
Looks like the world is going to ERC223, so the approve will make no sense.
PR https://github.com/Giveth/minime/pull/15 implements it. But I'm not convinced on this, because this functions might be called internally from a derived contract and what's checking are not the parameters but the...
@Dexaran I think that the main use of `data` will be some external reference like a saleId or an invoiceID or a deliveryID for example. I think it's good idea...
Many tokens like Status or Aragon have this extra protection since the beginning. Until now, I never heard a backward compatibility issue for this. I strongly believe that it doesn't...
Another thing, if you see the Implementation section in the standard, you will see Minime as an example of how to protect it. So I do think it's a good...
All the contracts will be deployed and verified in the Mainchain with enough time to be reviewed by the community. It's important not only to verify the code but also...
MultiSigWallet.sol and MiniMeToken.sol are standard contrancts. We took the decission not to touch those contracts unless a critical issue it's found.
In solidity, when a throw is raised, it rolls back the transaction, so it's not possible to trick the balances the way it's described here.
That was one of the last changes. If no SNT left for a user, now it throws. BTW Really thank you to extend the tests...
@janther : “Not allow new SGT tokens to be generated once contribution period has started” This test should not pass, because is theorically possible. SGT can be generated when Status...