status-network-token
status-network-token copied to clipboard
Low - 'if(!condition) throw;' should be avoided
This concerns many occurrences in source files MultiSigWallet.sol and MiniMeToken.sol.
There are several reason to use 'require(condition);' instead of 'if(!condition) throw;' :
-
Faster execution, consumes less gas
-
More clear : 'throw' naming is perturbing because it does not throw an exception that we can catch.
-
Solidity will certainly deprecate throw (https://github.com/ethereum/solidity/issues/1793).
MultiSigWallet.sol and MiniMeToken.sol are standard contrancts. We took the decission not to touch those contracts unless a critical issue it's found.