Pieter De Baets

Results 30 issues of Pieter De Baets

Summary: This was deprecated as part of bridgeless development, but since we now have `BridgelessReactContext`, which is also a `ReactContext`, this deprecation is no longer necessary. Changelog: [Internal] Differential Revision:...

CLA Signed
p: Facebook
Partner
fb-exported

Summary: We ran an experiment to test different implementations of TurboModules HostObjects, as the current one has various inefficiencies, such as re-creating HostFunctions on every property access. The strategy we...

CLA Signed
p: Facebook
Partner
fb-exported

Summary: Changelog: [Android][Fixed] PointerEvents were not dispatching after a scroll event Reviewed By: RSNara Differential Revision: D56519337

CLA Signed
p: Facebook
Partner
fb-exported

Summary: ReactSurfaceView overrides some of the same methods as ReactRootView, for which we can share the base class implementation. Changelog: [Internal] Differential Revision: D54496605

CLA Signed
p: Facebook
Partner
fb-exported

Summary: `Response` is `Closeable`, so we must close it even if the download is no longer relevant. Found while running with StrictMode enabled and reloading quickly multiple times. Differential Revision:...

CLA Signed
p: Facebook
Partner

Summary: Confirmed in https://github.com/facebook/react/commit/d779eba4b375134f373b7dfb9ea98d01c84bc48e that style properties already take priority over direct props, so we can avoid flattening style here. Changelog: [General][Fixed] Small performance tweak to View wrapper to avoid...

CLA Signed
p: Facebook
Partner

Summary: ViewManagers are all BaseJavaModule, and thus have access to methods like `getReactApplicationContext`. We don't expose the appropriate constructors though to pass this context down from the base class. Not...

CLA Signed
p: Facebook
Partner

Summary: * setInterval's second argument is optional, and defaults to 0 * setTimeout is spec'ed to return a positive integer. There's also no need to use HostObjects here to represent...

CLA Signed
p: Facebook
Partner
fb-exported

Summary: A common pattern to implement `ViewManagerOnDemandReactPackage` is to use a `getViewManagersMap` helper. If we capture `ReactApplicationContext` there, we will indefinitely retain the the very first ReactApplicationContext, and break/leak across...

CLA Signed
p: Facebook
Partner
fb-exported

Summary: TextInputs' onTextInput callback was removed way back in React Native 0.62 with https://github.com/facebook/react-native/commit/3f7e0a2c9601fc186f25bfd794cd0008ac3983ab , but remnants of the implementation exists. Fully remove references on JS side now that no...

CLA Signed
p: Facebook
Partner
fb-exported