Fix missing close for canceled bundle downloads

Open javache opened this issue 1 year ago • 1 comments

Summary: Response is Closeable, so we must close it even if the download is no longer relevant. Found while running with StrictMode enabled and reloading quickly multiple times.

Differential Revision: D56629079

Apr 26 '24 13:04 javache

Platform Engine Arch Size (bytes) Diff

android hermes arm64-v8a 19,460,084 -3

android hermes armeabi-v7a n/a --

android hermes x86 n/a --

android hermes x86_64 n/a --

android jsc arm64-v8a 22,833,626 -9

android jsc armeabi-v7a n/a --

android jsc x86 n/a --

android jsc x86_64 n/a --

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	19,460,084	-3
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	22,833,626	-9
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 67392cef3c8e036adfd9f77808419221d70f8f18 Branch: main

Apr 26 '24 13:04 analysis-bot

Merged as https://github.com/facebook/react-native/commit/dd51b38101a329abdf5edb9218e4bcda585c48eb

Jun 27 '24 20:06 javache