Jacob Merson

Results 19 issues of Jacob Merson

@ibaned Hoping to get your perspective on the following as a much more experienced developer. I did a little bit of work trying to fix up the const correctness of...

There are a few places where the REAL128 type specification is used that is not behind include guards which prevents pfunit from building.

bug

Is there a working example of creating the vtu file to be read into VTK with data on multiple ranks? I was able to get the vtx reader to work...

Fixes mesh reordering for with ghosting #364 . This pull request should be considered a draft until a test case is provided.

The changes here are fairly small, just using the correct "CMake" way to deal with language definitions. This should be more portable especially when using a newer version of CMake.

The `CMAKE_CXX_FLAGS` variable is overwritten by `bob_begin_cxx_flags`. I see that the variables `SCOREC_CXX_FLAGS` and `SCOREC_EXTRA_CXX_FLAGS` can be used instead. However, this behavior is not "standard" and I had to go...

This code uses c++11 features which are not available in the XL compiler suite. Is there a preferred method we are using to only enable certain features if the appropriate...

building
cmake

It turns our that if fields are frozen, then the field will not write out to an smb file.

fields
visualization
frozen fields

This is an example of one I ran into, but I assume there are more. ``` /gpfs/u/software/erp-spack-install/linux-centos7-x86_64/gcc-7.4.0/pumi-develop-rya3gf6vaxj4uiepwnwumgzjm6yossuh/include/apfVector.h:87:27: error: ‘fs.can::Array::elems[2]’ may be used uninitialized in this function [-Werror=maybe-uninitialized] c[i] = (*this)[i]...

This functionality is pulled over from my implementation in tobinw/biotissue. Valgrind is used to do memory checking, and gcov is used for coverage. closes #60 Note: I don't have an...