Update CMake CXX11 flags and disable openmpi warning

Open jacobmerson opened this issue 5 years ago • 3 comments

The changes here are fairly small, just using the correct "CMake" way to deal with language definitions. This should be more portable especially when using a newer version of CMake.

May 04 '20 02:05 jacobmerson

Thanks @jacobmerson.

Do you see any downside to making C++11 required?

If not, we should consider/discuss the changes here: https://github.com/SCOREC/core/tree/c++11Required . Issue #298 discusses some ctest failures with the XL compiler.

May 04 '20 13:05 cwsmith

I don't know if I'm the one qualified to discuss the downsides to enable c++11 by default...I think this really depends on the hardware we are expected to support. I.E. Is there hardware that core needs to run on which can't support c++11? I think most modern systems have support by now (even XL supports the full c++11 standard)

May 04 '20 18:05 jacobmerson

Given #345 I think this can be closed. If openmpi C++ interface warnings are still an issue we should create a new pr to fix it.

Jul 12 '21 18:07 cwsmith