Jackie Scanlon comments

Results 4 comments of


                                            Jackie Scanlon

Empty list not allowed as default value for PARAMETER_STRING_ARRAY

I'm currently using `get_parameter_or` as a workaround for this issue: ```py self.declare_parameter( "myparam", descriptor=ParameterDescriptor( type=rcl_interfaces.msg.ParameterType.PARAMETER_INTEGER_ARRAY, description="myparam description", ), ) param = self.get_parameter_or("myparam", rclpy.parameter.Parameter( "myparam", type_=rclpy.parameter.Parameter.Type.INTEGER_ARRAY, value=[], ), ).value ``` `param`...

Launch doesn't stop running nodes when exception thrown

I've also discovered a similar bug occurs when a typo is made in the keyword arguments for a Node, for example, mistyping `package` as `ackage`.

Add audio common ros2 branch to `iron` distribution

Ah yes, I have actually looked at the issue you linked and your PR before because we faced the same issue in our code base! I forgot you had mentioned...

Deserialize messages in bag using the message definitions in the bag

Thanks @MichaelOrlov , I've made https://github.com/ros2/ros2/issues/1603 accordingly.