Ishaan Agarwal

Results 20 comments of Ishaan Agarwal

Type Check Package

Hey, can I work on this issue ?

Type Check Package

Hey @guarin, some of the mypy tests are failing in local, 48 errors in 23 files in master, do you think I can still push my changes for the fix...

Type Check Package

Hey, @guarin Can you please review this PR - https://github.com/lightly-ai/lightly/pull/1651

Type Check Package

Wow, that is impressive.

Figure out if we can use tool to verify docstring format

Hey @guarin, do you think we can use this - https://pypi.org/project/pydocstringformatter/#what-it-does

Extract common / repetitive code from instrumentations into a new common library

Hey, can I work on this issue ?

Extract common / repetitive code from instrumentations into a new common library

Can you help me with one example of the code that is repetitive ?

Extract common / repetitive code from instrumentations into a new common library

So would you want one library for all the common the common code or a different library for OpenTelemetry Metrics creation and a different one for Checking if prompt logging...

Extract common / repetitive code from instrumentations into a new common library

okay, got it. Thanks

typecheck(cli/_helpers.py)

Partially fixes - https://github.com/lightly-ai/lightly/issues/1635