openllmetry icon indicating copy to clipboard operation
openllmetry copied to clipboard
verified publisher icon traceloop

Extract common / repetitive code from instrumentations into a new common library

Open nirga opened this issue 1 year ago • 8 comments

Which component is this bug for?

All Packages

📜 Description

Common things we have:

  • [ ] OpenTelemetry Metrics creation
  • [ ] Error reporting
  • [ ] Checking if prompt logging is allowed

Are you willing to submit PR?

None

nirga avatar Sep 20 '24 14:09 nirga

Hey, can I work on this issue ?

ishaanagw avatar Sep 20 '24 18:09 ishaanagw

Yes definitely @ishaanagw!

nirga avatar Sep 20 '24 18:09 nirga

Can you help me with one example of the code that is repetitive ?

ishaanagw avatar Sep 20 '24 19:09 ishaanagw

This one for example

https://github.com/traceloop/openllmetry/pull/1957#discussion_r1767317525

nirga avatar Sep 20 '24 20:09 nirga

So would you want one library for all the common the common code or a different library for OpenTelemetry Metrics creation and a different one for Checking if prompt logging is allowed, and so on ?

ishaanagw avatar Sep 20 '24 20:09 ishaanagw

One library to rule them all. Maybe we can even put it in the ai semconv library we already have

nirga avatar Sep 20 '24 20:09 nirga

okay, got it. Thanks

ishaanagw avatar Sep 20 '24 20:09 ishaanagw

is it still open for contribution?

Karush2807 avatar Oct 01 '24 19:10 Karush2807