Gregory Sanders

output would be nice in json

6

:)

Verify PSBT inputs rather than check for fields being empty

1

In a few keys spots, PSBT finality is checked by looking for non-empty witness data. This complicates a couple things: 1) Empty data can be valid in certain cases 2)...

PNG says SHA356 instead of SHA256 https://github.com/lnbook/lnbook/blob/develop/images/mtln_aa01.png

android: copying address for deposit adds leading/trailing whitespace

1

made it hard to send when the sending wallet didn't let me know there were spaces

QR code page shouldn't show balance

4

I can't take a screenshot of QR code for posting anywhere without showing my LN balance

update bip0129 to reduce ambiguity

2

I read it as "both types accepted" and couldn't find the definition of the signature format for non-p2pkh scripts, leading me to reread this section again after reading the BIP322....

I find it difficult to reason about as-written, even if implicitly it may be correct. cc @ajtowns

[BIP 141] slight witness version byte push clarification

1

To me at least, 1-byte push could include `0x01` followed by the version number.

reissuance tokens can not be exercised from unblinded outputs

13

In the current logic, `CAssetIssuance`'s `assetBlindingNonce` being null implies that the issuance is an initial issuance. When re-issuing, this field is re-used to expose the asset blinder for the spent...

blinding_derivation_key should be generated in HD path

2

Currently all keys except the blinding derivation key are generated via HD wallet. Using `GenerateNewKey` would enable HD derivation of that key making backups easier, and would allow us to...