Gregory Sanders

Results 392 comments of Gregory Sanders

Well, spelling "address" right is preferable but yes anything that `jq` can parse is great for bash type usage

concept ACK, cool to see such an old idea actually get implemented

Would be nice to give some log feedback that the anti-DoS header sync has at least started. Currently for testnet it's ~3 minutes of nothing of use being printed. related...

Logging looks great! edit: Gah, it just took my node forever to find a peer to give me all the headers after a disconnect I guess. peerinfo is showing a...

> Why not simply ensure the headers are removed from memory and store them on disk for later access? "simply" generally is not as simple as we'd like, and doesn't...

> Plus, this PR is about only downloading "enough PoW" which means you don't need anywhere near that much disk space. Seems like the ideal way to do this is...

ACK https://github.com/bitcoin/bitcoin/pull/25664/commits/b16f93caddcd3254eaf3dc43e09adf2142a9c40a

Hadn't occurred to me this implicit limit due to the encoding of xpub/xprv. utACK https://github.com/bitcoin/bitcoin/pull/25642/commits/fb9faffae3a26b8aed8b671864ba679747163019

Given the document `doc/policy/mempool-replacements.md` already exists(and explains the relationship to bip125), concept ACK