Andreas Klöckner
Andreas Klöckner
Unsubscribing... @-mention or request review once it's ready for a look or needs attention.
Thanks for the small reproducer, that helps! I think part of the problem here is that `SVMAllocation` holds a reference to the CL context in a `shared_ptr`: https://github.com/inducer/pyopencl/blob/f5e1b7b7acdf5beaf3d9435163ad4d099e36dd7a/src/wrap_cl.hpp#L3700 It needs...
*Actually*, we may be dealing with what's described as the "uncollectable inter-language reference cycle" in [nanobind's docs for intrusive RC](https://nanobind.readthedocs.io/en/latest/ownership_adv.html#intrusive).
I feel like we should move to intrusive refcounting for context, queue, memory pools, and allocators. I'm out of time for today, but if you have time to get this...
#759 is a start that already addresses your small reproducer.
Thanks for spotting that! For posterity: ``` nanobind: leaked 7 instances! - leaked instance 0x55eb67f303f0 of type "pyopencl._cl.Device" - leaked instance 0x55eb67f697e0 of type "pyopencl._cl.Device" - leaked instance 0x55eb680ec850 of...
@vincefn The incidence of these should be substantially reduced post b659cad93a6f97535ea7fdd1c0c7c7e9b71f7a3e (unreleased). It might be good to disable these for release builds by default, because they don't have much utility...
Thanks for flagging that discussion in the Urwid docs! I agree that these light backgrounds are... not as beautiful as they could be. A PR to fix this would be...
No, not in this case. This code: ``` pre_density_discr = Discretization( actx, mesh, InterpolatoryQuadratureGroupFactory(target_order) ) vis = make_visualizer(actx, pre_density_discr, target_order) ``` makes pre-density as GL and vis as GLL, I...
Side note: please disregard the RUF052 (https://github.com/astral-sh/ruff/issues/14796) and pylint linter failures (https://github.com/pylint-dev/pylint/issues/10000#issuecomment-2519899671).