Andreas Klöckner comments

Results 957 comments of


                                            Andreas Klöckner

pyopencl does not respect OCL_ICD_FILENAMES

I'm confused here. - PyOpenCL is not specific to any ICD loader, it works with Khronos and other loaders. The wheel also does not ship a specific loader. - For...

Add support for attribute(()) in enum/struct/union

Thanks for the contribution! Could you fix the linter failure? Otherwise this LGTM.

Add support for attribute(()) in enum/struct/union

> But this only matches if there is an `__attribute__(())` in each position Not sure I understand. Wouldn't each `attributes_opt` be optional individually?

added alignof gnu extension support

Could you look into the linter failure?

added alignof gnu extension support

Could you add support for this to the generator and add a round-trip test?

added alignof gnu extension support

LGTM, thanks!

Implements a Loop Fusion Transformation

This could be rebased now that the prerequisite `generate_loop_schedule_v2` is in.

Implements a Loop Fusion Transformation

Pushed some cosmetic fixes. This was complex to review, but I think I've got a decent understanding of it now. LGTM, in it goes!

Incorrect parse on struct field that is a pointer to a function with attributes that returns a function pointer

Thanks for the report! I'm unlikely to have time to dig into this anytime soon, but I'd be happy to look at a patch (ideally with a test).

Incorrect parse on struct field that is a pointer to a function with attributes that returns a function pointer

Closed by #92.