Isaac Morales Santana

Results 12 comments of Isaac Morales Santana

FetchContent doesn't have a progress bar like wget. Instead, it prints messages from 0% to 100%.

It appears that FetchContent creates a new folder, "_deps," with subbuild files. When the macOS workflow attempts to redownload ROOT, the script doesn't detect it. However, the "_deps" folder remains,...

I didn't know how to enable deep sleep too

Done. The issue arises when contributors fork the repository and create branches. The workflows fail because it attempt to locate the branch in the main repository. As the branch doesn't...

Could you review the code? @LukasBreitwieser @FonsRademakers @TobiasDuswald Feel free to request as many changes as needed. I want to know how I'm doing, and try to improve my code....

> This looks reasonable to me. Maybe we should remove the whitespace changes and configure the editor to not do them automatically. > > That change is a small but...

> @imorlxs @vgvassilev can you comment if and how that affects the codebase or it's compilation? Does it compile identically, e.g., is genreflex a deprecated command that we now replace...

I have no clue... I just re-run the jobs and now they pass ^^"

Hi @vasvav. The purpose of this PR is to replace genreflex. As @vgvassilev said, since ROOTv6. genreflex is nothing but a wrapper around rootcling [1](https://root.cern.ch/root/htmldoc/guides/users-guide/AddingaClass.html#genreflex-a-comfortable-interface-to-rootcling) Genreflex doesn't have the options...

I tested the changes on a fork of the repository and seems to work fine with different repository and branch names.